Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve(HubPoolClient): Remove originChain LP fee constraint #556

Merged
merged 9 commits into from
Feb 21, 2024
Merged

improve(HubPoolClient): Remove originChain LP fee constraint #556

merged 9 commits into from
Feb 21, 2024

Commits on Feb 14, 2024

  1. improve(HubPoolClient): Remove originChain LP fee constraint 

    Remove a constraint in batch LP fee computation by permitting any
unsorted array of deposit objects, rather than requiring the array be
filtered for a single origin chain. This turned out to be a fairly
simple change, and allows an actor (i.e. the relayer) to batch-compute
the LP fee for a large array of deposits.

A follow up change will update the function prototype to accept a
repaymentChainId.
    @pxrl
    pxrl committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    11dad3b View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Update package.json

    @nicholaspai
    nicholaspai committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    cb08d08 View commit details
    Browse the repository at this point in the history

  2. Update package.json

    @nicholaspai
    nicholaspai committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    daee1c6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into pxrl/batchCompute

    @nicholaspai
    nicholaspai committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    3c9be9d View commit details
    Browse the repository at this point in the history

  4. Update types

    @pxrl
    pxrl committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    64a91a2 View commit details
    Browse the repository at this point in the history

  5. Remove undefined paymentChainId scenario

    @pxrl
    pxrl committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    dbee44a View commit details
    Browse the repository at this point in the history

  6. Revert "Remove undefined paymentChainId scenario" 

    This reverts commit dbee44a.
    @nicholaspai
    nicholaspai committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    f3335e4 View commit details
    Browse the repository at this point in the history

  7. Update HubPoolClient.ts

    @nicholaspai
    nicholaspai committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    83f4d9e View commit details
    Browse the repository at this point in the history

  8. Update HubPoolClient.ts

    @nicholaspai
    nicholaspai committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    3b76ffb View commit details
    Browse the repository at this point in the history