Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve(arweave): handle out of gas error #558

Merged
merged 2 commits into from
Feb 16, 2024
Merged

improve(arweave): handle out of gas error #558

merged 2 commits into from
Feb 16, 2024

Conversation

james-a-morris
Copy link
Contributor

We should explicitly handle the path where we are out of gas. This should unwind the stack to the calling function.

nicholaspai
nicholaspai approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@nicholaspai nicholaspai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we set up an automatic way to replenish the arweave account? Similar to how we do so for the dataworker in the Monitor code

@james-a-morris
Copy link
Contributor Author

Can we set up an automatic way to replenish the arweave account? Similar to how we do so for the dataworker in the Monitor code

Tracked in ACX-1903

@james-a-morris james-a-morris merged commit 913284d into master Feb 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholaspai nicholaspai nicholaspai approved these changes

@pxrl pxrl Awaiting requested review from pxrl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@james-a-morris @nicholaspai