Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] improve(HubPoolClient): Don't throw on token resolution failure #643

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

[WIP] improve(HubPoolClient): Don't throw on token resolution failure #643

wants to merge 4 commits into from

Commits on May 10, 2024

  1. improve(HubPoolClient): Don't throw on token resolution failure 

    This is too violent for a lot of use cases and requires callers to wrap
their calls in try/catch statements, which has its own set of problems.
Instead, just return undefined if the requested token can't be resolved
and allow the caller to decide on how to respond to that.
    @pxrl
    pxrl committed May 10, 2024
    Configuration menu
    Copy the full SHA
    070bb0c View commit details
    Browse the repository at this point in the history

  2. lint

    @pxrl
    pxrl committed May 10, 2024
    Configuration menu
    Copy the full SHA
    0a21246 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Merge branch 'master' into pxrl/undefinedToken

    @bmzig
    bmzig committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    c23eb42 View commit details
    Browse the repository at this point in the history

  2. basic accomodation for undefined 

    Signed-off-by: bennett <bennett@umaproject.org>
    @bmzig
    bmzig committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    384853b View commit details
    Browse the repository at this point in the history