Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: migrate bundle data client #709

Merged
merged 12 commits into from
Aug 27, 2024

Conversation

james-a-morris
Copy link
Contributor

@james-a-morris james-a-morris commented Aug 21, 2024

This PR aims to migrate the Bundle Data Client and its supporting functions into the SDK

--

Review code diffs since:

  1. The initial copy/paste of the bundle data client: de738a9...james/acx-2443-refactor-sdk-contract-clients
  2. The initial copy/paste of the top level supporting functions: 366a96f...james/acx-2443-refactor-sdk-contract-clients
  3. The initial copy/paste of the supporting functions needed for the supporting functions: 6fcff5d...james/acx-2443-refactor-sdk-contract-clients
  4. The initial copy/paste of the supporting functions for step 3: e5c8b22...james/acx-2443-refactor-sdk-contract-clients

Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
@james-a-morris james-a-morris marked this pull request as draft August 21, 2024 16:01
Copy link

linear bot commented Aug 21, 2024

james-a-morris and others added 4 commits August 21, 2024 12:02
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
@james-a-morris james-a-morris force-pushed the james/acx-2443-refactor-sdk-contract-clients branch from c7d4f71 to 97f9680 Compare August 23, 2024 17:09
@james-a-morris james-a-morris marked this pull request as ready for review August 23, 2024 17:32
Copy link
Member

@nicholaspai nicholaspai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Assuming pure copy and paste, these util files haven't changed in the relayer-v2 repo since you opened the PR 2 days ago

Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
@james-a-morris james-a-morris changed the title WIP: migrate bundle data client improve: migrate bundle data client Aug 26, 2024
Copy link
Contributor

@amateima amateima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@james-a-morris james-a-morris merged commit 28990aa into master Aug 27, 2024
4 checks passed
@pxrl pxrl deleted the james/acx-2443-refactor-sdk-contract-clients branch September 21, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants