refactor: Centralise BigNumber imports #725
Conversation
Avoid importing BigNumber from ethers directly throughout the repository, and instead just re-export the standalone ethers BigNumber variant from src/utils/BigNumberUtils. This should make it easier to migrate away from ethers v5.
Yeah, hopefully this achieves that. It's a bit tricky to be 100% sure but I've eliminated as many cases of importing directly from ethers as I could identify. If we implement a BigInt -> BigNumber shim then we might be able to play with v6. |
There was a problem hiding this comment.
This looks really tedious to have implemented. 👏
Looks good though I'd make one improvement, since we don't know how long it's going to take to move over to viem, we can maybe add an eslint rule to restrict importing BigNumber from ethers?
https://eslint.org/docs/latest/rules/no-restricted-imports#paths
There was a problem hiding this comment.
Nice work! I think this shouldn't break anything on the FE AFAICT. Also really like @gsteenkamp89 suggestion
Avoid importing BigNumber from ethers directly throughout the repository, and instead just re-export the standalone ethers BigNumber variant from src/utils/BigNumberUtils. This should make it easier to migrate away from ethers v5.