Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update Polygon GasStation implementation #734

Merged
merged 4 commits into from
Sep 17, 2024
Merged

chore: Update Polygon GasStation implementation #734

merged 4 commits into from
Sep 17, 2024

Conversation

pxrl
Copy link
Contributor

@pxrl pxrl commented Sep 17, 2024 •
edited
Loading

Changes:

  • Bump timeout from 1.5s to 2s.
  • Reduce retries from 1 to 0.
  • Enforce a minimum of 30 Gwei priority on gas station failure.
  • Set HTTP user agent to "across-protocol" and permit overriding via the environment.
  • Incidental cleanup.

This change is made on request from the Polygon team to support troubleshooting of repeat timeouts on the GasStation API.

@pxrl
chore: Bump Polygon GasStation timeout to 2s, 0 retries
076cd36 
Plus some other incidental cleanup in this file.
@pxrl pxrl requested review from dohaki and bmzig September 17, 2024 08:08
@pxrl pxrl changed the title chore: Bump Polygon GasStation timeout to 2s, 0 retries chore: Update Polygon GasStation implementation Sep 17, 2024
gsteenkamp89
gsteenkamp89 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@gsteenkamp89 gsteenkamp89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@pxrl pxrl merged commit fcd1201 into master Sep 17, 2024
4 checks passed
@pxrl pxrl deleted the pxrl/polygonGas branch September 17, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsteenkamp89 gsteenkamp89 gsteenkamp89 approved these changes

@dohaki dohaki Awaiting requested review from dohaki

@bmzig bmzig Awaiting requested review from bmzig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pxrl @gsteenkamp89