Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace ethers Event with Log #738

Merged
merged 6 commits into from
Sep 20, 2024
Merged

refactor: Replace ethers Event with Log #738

merged 6 commits into from
Sep 20, 2024

Commits on Sep 19, 2024

  1. refactor: Replace ethers Event with Log

    The ethers Event type is an extension of the underlying Log type, which
    is actually the type that contains almost all of the event data that the
    SDK needs for Across. Since Event extends Log, it's safe to narrow the
    scope of the RPC data down to a Log type. This significantly reduces the
    delta to viem's Log type and is a key stepping stone for viem and ethers
    to be used interchangeably for RPC interfacing & transport.
    
    It additionally seems like this simplification _might_ also support
    Solana events (...with some eventual coercion).
    pxrl committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    96d00b0 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Configuration menu
    Copy the full SHA
    487e572 View commit details
    Browse the repository at this point in the history
  2. Use unknown instead of any

    Spotted by James.
    pxrl committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6df63d0 View commit details
    Browse the repository at this point in the history
  3. Disable faulty test

    pxrl committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    d079811 View commit details
    Browse the repository at this point in the history
  4. Comment

    pxrl committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7ca4345 View commit details
    Browse the repository at this point in the history
  5. Bump minor

    pxrl committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    361a9b5 View commit details
    Browse the repository at this point in the history