Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How come our IDs don't use [g-z]? #1339

Closed
WilcoFiers opened this issue Jun 9, 2020 · 2 comments · Fixed by #1358
Closed

How come our IDs don't use [g-z]? #1339

WilcoFiers opened this issue Jun 9, 2020 · 2 comments · Fixed by #1358
Assignees

Comments

@WilcoFiers
Copy link
Member

WilcoFiers commented Jun 9, 2020

I noticed this going through our list of rules this week, having all the URLs in one long list. With very few exceptions, the IDs use either a number, or the letters A through F. It strikes me that that's a hex range, and that when we're creating IDs we're not using the full [0-9a-z] range.

Looking more closely, the only rules that I found actually had letters in the G-Z range were ones I authored.

To be specific, there is a list of 50 rules here #1120 (comment), only 4 of them use chars in G-Z in their ID.

@Jym77
Copy link
Collaborator

Jym77 commented Jun 9, 2020

https://act-rules.github.io/pages/design/rule-design/#rule-identifier

The 6-digit identifier is created using a random hex generator, such as https://www.browserling.com/tools/random-hex. The identifier remains the same if the rule name changes.

That doesn't explicitly restrict to hexadecimal identifiers but certainly pushes strongly in that direction…

@WilcoFiers
Copy link
Member Author

Here's a generator that will give us what we need:

https://www.random.org/strings/?num=1&len=6&digits=on&loweralpha=on&unique=on&format=html&rnd=new

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants