Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGENDA ITEM: Rules ready for W3C publication #1120

Closed
WilcoFiers opened this issue Jan 23, 2020 · 9 comments
Closed

AGENDA ITEM: Rules ready for W3C publication #1120

WilcoFiers opened this issue Jan 23, 2020 · 9 comments

Comments

@WilcoFiers
Copy link
Member

WilcoFiers commented Jan 23, 2020

This is a recurring agenda item.

We need to look at all the rules that have more than 2 implementations that have not yet been submitted to the ACT Task Force for publication, and assign people to submit these.

Before submission: Make sure the rule has no open issues, and ensure the rule is up to date:

  1. Do the example descriptions match the current format
  2. Are all the notes strictly necessary
  3. Ensure lists follow the list format

To submit a rule, create a new issue in the following repo: https://github.com/w3c/wcag-act/issues

Use the following template for the proposal

Issue name: "{{new | updated}} rule: {{rule title}}"

Issue body:

The ACT-Rules community group has completed work on {{rule name}}. We would like to see this rule be added to the WCAG ruleset. You can find the rule here:

**Rule title**: ...
**Rule id**: ...
**Link to the rule**: ...
**License**: W3C Software And Document Notice And License
**Implementors**:
- {{Implementor name}}
- {{Implementor name}}
- ...

If you'd like to contact me, please e-mail me at myemail@mycompany.com. (optional: You can also reach me on the W3C Community Slack, my name there is <<name>>)

For details, see the WCAG ruleset review process as described by the ACT Task Force.

@jeeyyy jeeyyy changed the title Rules ready for W3C publicatoin Rules ready for W3C publication Feb 4, 2020
@jeeyyy jeeyyy changed the title Rules ready for W3C publication AGENDA ITEM: Rules ready for W3C publication Feb 4, 2020
@WilcoFiers
Copy link
Member Author

WilcoFiers commented Feb 13, 2020

Accepted

Rule Owner Issues / PRs
HTML page has non-empty title @WilcoFiers
Image button has non-empty accessible name @WilcoFiers
HTML page has lang attribute @WilcoFiers
HTML page language is valid @Jym77
HTML page lang and xml:lang attributes have... @JKODU
id attribute value is unique @Jym77
svg element with explicit role has non-empty... @Jym77
meta viewport does not prevent zoom @carlosapaduarte
Link has non-empty accessible name @carlosapaduarte
Button has non-empty accessible name @WilcoFiers
Form control has non-empty accessible name @WilcoFiers
ARIA state or property is permitted @Jym77
aria-* attribute is defined in WAI-ARIA @JKODU
Image has non-empty accessible name @WilcoFiers

W3C Changes Requested

Rule Owner Issues / PRs Due date
All table header cells have assigned data cells @ajanec01 w3c/wcag-act#476 #1548
Orientation of the page is not restricted using... @carlosapaduarte w3c/wcag-act#481
autocomplete attribute has valid value @ajanec01 w3c/wcag-act#501 #1549
Element marked as decorative is not exposed @carlosapaduarte w3c/wcag-act#493 w3c/wcag-act#504
meta element has no refresh delay @HelenBurge w3c/wcag-act#495 w3c/wcag-act#505
audio or video avoids automatically playing audio @Jym77 w3c/wcag-act#490 w3c/wcag-act#506
iframe Element has non-empty Accessible Name @WilcoFiers w3c/wcag-act#435 w3c/wcag-act/issues/473
Object element has non-empty accessible name @carlosapaduarte w3c/wcag-act#479
ARIA required context role @Jym77 w3c/wcag-act#499 w3c/wcag-act#507 #1554
Heading has non-empty accessible name @Jym77 w3c/wcag-act#500 w3c/wcag-act#510

Awaiting W3C resolution

Rule Owner Issues / PRs Due date
Scrollable element is keyboard accessible @WilcoFiers w3c/wcag-act#484
Visible label is part of accessible name @WilcoFiers w3c/wcag-act#491
Headers attribute specified on a cell refers to... @ajanec01 w3c/wcag-act#503
Element within body has valid lang attribute @WilcoFiers #1383 w3c/wcag-act#431
Links with identical accessible names have... @HelenBurge w3c/wcag-act#509
Menuitem has non-empty accessible name Sameera w3c/wcag-act#508
role attribute has valid value @Jym77 w3c/wcag-act#492

Ready for W3C

Rule Owner Issues / PRs Due date
iframe elements with identical accessible names...
Element in sequential focus order has visible focus
Element with presentational children has no focu...

Implemented, has issues to resolve

Rule Owner Issues / PRs Due date
ARIA state or property has valid value @WilcoFiers #1432 #1433
Element with aria-hidden has no focusable content @carlosapaduarte #643 #1444
Links with identical accessible names and conte...

Blocked rules

Rule Owner Issues / PRs Due date
ARIA required owned elements @ajanec01 w3c/wcag-act#468 w3c/aria#1033
Element with role attribute has required states... Awaiting ARIA 1.2

Awaiting implementations

Rule Owner Issues / PRs
Text has minimum contrast @WilcoFiers w3c/wcag-act#485
video element visual-only content has accessible... @carlosapaduarte
audio element content has text alternative #1346
video element auditory content has accessible... #1347
Attribute is not duplicated
Device motion based changes to the content ...
Device motion based changes to the content can...
Error message describes invalid form field value
Focusable element has no keyboard trap
Heading is descriptive
HTML page title is descriptive
Image accessible name is descriptive
Image not in the accessibility tree is decorative
Link in context is descriptive
Text content that changes automatically can be ...
video element visual content has accessible...
video element visual content has strict accessi...
Zoomed text node is not clipped with CSS overflow
HTML page language subtag matches default language
No keyboard shortcut uses only printable characters
Letter spacing in style attributes is not !impo...
Line height in style attributes is not !important
Word spacing in style attributes is not !important
Content has alternative for visual reference

@Jym77
Copy link
Collaborator

Jym77 commented Feb 28, 2020

@WilcoFiers should we mention (in the original message of this issue) that before submitting a rule we should go through a clean up of examples and examples descriptions? (given that so many of them have pretty low quality and we can probably spare some work to reviewers and some time in the process)

@Jym77
Copy link
Collaborator

Jym77 commented Mar 17, 2020

@WilcoFiers how do we (submitters) make sure the list is kept up-to-date?

Should we update #1120 (comment) (probably a bad idea to all update the same message, that will generate mistakes…)? Should we just write messages in this issues so you can handle the updates to the list (might be a bit noisy, but that should be OK-ish given that it will be the only noise in that issue, also put some centralisation work on you)?

Anyway: w3c/wcag-act#440

@jeeyyy
Copy link
Collaborator

jeeyyy commented Mar 20, 2020

Note: Updated above body of the main comment to move an item (w3c/wcag-act#442) into Ready for W3C listing. @WilcoFiers please add relevant labels for the issue in WCAG ACT repository.

@WilcoFiers
Copy link
Member Author

FYI: I'll update this list before every ACT-R call. No need for others to do so.

@Jym77
Copy link
Collaborator

Jym77 commented Sep 2, 2020

Do you think it would be possible to add that template to the WCAG-ACT repo? So we could just open a new issue and fill the gaps…

Use the following template for the proposal

Issue name: "{{new | updated}} rule: {{rule title}}"

Issue body:

The ACT-Rules community group has completed work on {{rule name}}. We would like to see this rule be added to the WCAG ruleset. You can find the rule here:

**Rule title**: ...
**Rule id**: ...
**Link to the rule**: ...
**License**: W3C Software And Document Notice And License
**Implementors**:
- {{Implementor name}}
- {{Implementor name}}
- ...

If you'd like to contact me, please e-mail me at myemail@mycompany.com. (optional: You can also reach me on the W3C Community Slack, my name there is <<name>>)

@Jym77
Copy link
Collaborator

Jym77 commented Sep 11, 2020

Yesterday we mentioned cleaning the "accepted" table. I'm now less sure about it.
I just used it to have a quick overview of how many (and which) rules are already published by W3C (for communication) and found it very handy to have all info here…

OTOH, maybe this issue should be a wiki page instead to have a bit more structure?

@Jym77
Copy link
Collaborator

Jym77 commented Oct 1, 2020

Issue name: "{{new | updated}} rule: {{rule title}}"

I keep running into the "issue" that the submission can be in a third state than new/updated, namely "resubmit" (or something like that).
Most of our rules go through the TF several time before being accepted, with feedback each time. The first time, the rule is definitively a "new" rule as far as TF is concerned, but the second and subsequent times, it is less clear. The rule is not really "new" since the TF has already seen it, but is not really "updated" since, the TF has not accepted it yet. Plus, it might be valuable to link from the second submission into the older "resolving" issues to help the TF keep track of its previous comments.

So far, when resubmitting after feedback and correction, I use the "updated rule" title with the template as is (so no link to previous survey results). But I'm not convinced this is the most helpful for the TF…

@WilcoFiers
Copy link
Member Author

Closing the issue. This work is going to be done by the ACT TF going forward, which uses their own way to track progress. Don't need this issue anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants