Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wcag-ruleset-review-process.md #515

Merged
merged 9 commits into from
Apr 20, 2021
Merged

Conversation

WilcoFiers
Copy link
Collaborator

@WilcoFiers WilcoFiers commented Mar 22, 2021

How this improves the process

The proposed process is different from the current ACT rule review process in the following ways:

  1. The ACT Rules community group website is dropped. Rules are published directly to the WAI website, but with an indication that the rule is "proposed". Implementation tracking too is done on the WAI website. Any guidance on rule writing, process descriptions, and the definition of done is used directly in the github repository.

  2. ACT TF members will have an active role in updating rules. In their review, TF members propose changes. Instead of handing feedback to the rule author, the liaison is responsible for drafting any necessary changes themselves.

  3. The validation process now involves both members from the TF and the CG, instead of being exclusive to the community group.

  4. Instead of having two separate but connected processes, one managed by the CG and the other by the TF, a single process exists that is maintained by the TF.

  5. There is no longer a separate CFC step in the Task Force. The survey is essentially the CFC; and not answering the survey is akin to not responding on a CFC.

  6. The "final call" step in the CG is renamed to "Call for review", as this step is no longer the "final" step in the process.


The ACT Task Force will send a request for change to a rule provider as a result of either public feedback or an annual review. If the rule provider does not respond within two months, the ACT Task Force will assume the rule is no longer actively maintained. The ACT Task Force will send at least 2 reminders before concluding the rule is not maintained. If a rule is not maintained, the ACT Task Force will look for another organization who might be willing to maintain the rule. If the original rule provider wishes to resume maintenance of the rule, this will only be accepted with the permission of the active rule provider.
For the ACT Task Force agenda, public feedback will be prioritised over review of proposed rules. This ensures responsiveness to the wider community. The ACT Task Force should respond to questions within 5 work days. This may be a reply which indicates when an answers is expected.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For the ACT Task Force agenda, public feedback will be prioritised over review of proposed rules. This ensures responsiveness to the wider community. The ACT Task Force should respond to questions within 5 work days. This may be a reply which indicates when an answers is expected.
For the ACT Task Force agenda, public feedback will be prioritised over review of proposed rules. This ensures responsiveness to the wider community. The ACT Task Force should respond to questions within 5 work days. This may be a reply which indicates when an answer is expected.

wcag-ruleset-review-process.md Outdated Show resolved Hide resolved
wcag-ruleset-review-process.md Outdated Show resolved Hide resolved
wcag-ruleset-review-process.md Outdated Show resolved Hide resolved
wcag-ruleset-review-process.md Outdated Show resolved Hide resolved
wcag-ruleset-review-process.md Outdated Show resolved Hide resolved
wcag-ruleset-review-process.md Outdated Show resolved Hide resolved

Questions the ACT Task Force can answer will be responded to directly. Questions that may require updates to a rule will be forwarded to the rule provider, including a proposal from the ACT Task Force on how to resolve the question. If the rule provider uses the proposal without additional changes, the rule will be updated without having to go through the review process. The rule provider should still apply their own review process to the change. If a different solution is taken, or additional changes are made, the update will have to go through the review process.
2. If AG requests editorial changes, a [drafts proposal](#1-draft-proposal) is created. Once merged, the updated rule is republished on the WAI website with the "proposal" indicator removed. This skips the implementations or validation steps.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. If AG requests editorial changes, a [drafts proposal](#1-draft-proposal) is created. Once merged, the updated rule is republished on the WAI website with the "proposal" indicator removed. This skips the implementations or validation steps.
2. If AG requests editorial changes, a [draft proposal](#1-draft-proposal) is created. Once merged, the updated rule is republished on the WAI website with the "proposal" indicator removed. This skips the implementations or validation steps.

wcag-ruleset-review-process.md Outdated Show resolved Hide resolved
@WilcoFiers WilcoFiers marked this pull request as ready for review March 25, 2021 13:07
wcag-ruleset-review-process.md Outdated Show resolved Hide resolved
wcag-ruleset-review-process.md Show resolved Hide resolved
wcag-ruleset-review-process.md Outdated Show resolved Hide resolved
wcag-ruleset-review-process.md Outdated Show resolved Hide resolved
Copy link

@annethyme annethyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an "outsider" to what has been discussed on the process in this round, it looks really good, well-described and with one relatively easy to understand process from draft rule to official publication. Well done!
The only more general questions I have after intitially reading this is where the boundary between CG and TF is? And these "liaisons" where do they come from? (I unfortunately don't have time to read through another time to see if I could actually find the answers in the text, if reading more carefully).
I have noted down a few editorial comments as well.

wcag-ruleset-review-process.md Outdated Show resolved Hide resolved
wcag-ruleset-review-process.md Outdated Show resolved Hide resolved

Much of the tasks in this process are delegated to ACT Task Force, which is a sub-group of AGWG. ACT TF carries out initial review and prepares proposals for AGWG, which has the final say as the maintainer of WCAG and the authoritative body for interpretation.

Organizations and individuals, **rule providers**, can submit rules to be added to the WCAG Ruleset. Submitted rules must conform to the ACT Rules Format 1.0 specification and be accompanied by real-life implementations (specific criteria detailed later in this document). **Rule providers are expected to only contribute complete rules, as accurate as the rule providers can possibly make them.**
The ACT TF does this work in close collaboration with the ACT Rules Community Group through regular joint meetings. Any other groups interested to contribute rules to the WCAG ruleset should contact the co-facilitator(s) of the ACT Task Force. The ACT publication process is designed to publish high-quality ACT rules to the W3C website.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "interested to contribute" correct, og should it be "interested in contributing"?
I at least found it a bit hard to read.

Found this on the subject (https://jakubmarian.com/interested-in-doing-vs-interested-to-do-in-english/):
“Interested to” can be used only with verbs of perception and “knowing”, such as:see, hear, read, learn, know, find out, …

Co-authored-by: daniel-montalvo <49305434+daniel-montalvo@users.noreply.github.com>
Co-authored-by: Trevor R. Bostic <32486143+tbostic32@users.noreply.github.com>
WilcoFiers and others added 2 commits March 25, 2021 16:48
Co-authored-by: daniel-montalvo <49305434+daniel-montalvo@users.noreply.github.com>

Organizations and individuals, **rule providers**, can submit rules to be added to the WCAG Ruleset. Submitted rules must conform to the ACT Rules Format 1.0 specification and be accompanied by real-life implementations (specific criteria detailed later in this document). **Rule providers are expected to only contribute complete rules, as accurate as the rule providers can possibly make them.**
Rule writing, reviewing, approving, and maintaining is a joint work between the ACT TF and the ACT Rules Community Group through regular joint meetings. Any other groups interested in contributing rules to the WCAG ruleset should contact the co-facilitator(s) of the ACT Task Force. The ACT publication process is designed to publish high-quality ACT rules to the W3C website.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest "...joint work effort between..."

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless a new co-facilitator was found, "co-facilitators" should be "facilitator."


## Annual Review
3. If AG requests non-editorial, the liaison is tasked to create a [draft proposal](#1-draft-proposal).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should say "...non-editorial changes..."

Copy link
Contributor

@daniel-montalvo daniel-montalvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor suggestions.

wcag-ruleset-review-process.md Outdated Show resolved Hide resolved
wcag-ruleset-review-process.md Outdated Show resolved Hide resolved
wcag-ruleset-review-process.md Outdated Show resolved Hide resolved
Co-authored-by: daniel-montalvo <49305434+daniel-montalvo@users.noreply.github.com>
@WilcoFiers WilcoFiers merged commit 9fb697a into master Apr 20, 2021
@WilcoFiers WilcoFiers deleted the review-process-update-2 branch April 20, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants