-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ARIA state or property has valid value rule to current writing style #1433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change in Applicability is breaking the rule.
The rest are mostly editorials.
**Note:** Only for [WAI-ARIA required properties][] with value types `ID Reference` and `ID Reference List` is there a requirement that the elements with the given ids actually exists. For non-required properties, this is not a requirement. | ||
|
||
**Note:** | ||
For value type `URI`, this rule does not require that the destination URI exists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The notes could probably move to the Background section. The first one might be expanded a bit to explain why this extra requirement is only for required properties (why is it OK for non-required properties to reference non-existing IDs).
(the second note is fairly obvious: the rule checks the syntax of the URL, but is not a broken link checker)
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
@Jym77 thanks for the round of review. I am not entirely following your argument around - "not mandatory for non-required properties to reference non-existing IDs". Help appreciated. Other comments have been addressed. |
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1433 (comment) and #1433 (comment) still need to be addressed.
|
||
**Note:** | ||
For value type `URI`, this rule does not require that the destination URI exists. | ||
Each test target has a valid value according to its [WAI-ARIA 1.1 value type][]. For [WAI-ARIA required properties][] with [value type][] of `ID reference` and `ID reference list` at least one of the referenced elements with the given ids should exist in the same [document tree][] or [shadow tree][]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please review the comments again? This rule stats that these only need to exist if the ARIA attribute is required for that role.
Closing, going to start from scratch. |
Need for Final Call: