Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

Allow setting a title for the created check run #11

Merged
merged 4 commits into from
Oct 29, 2019

Conversation

garyttierney
Copy link
Contributor

This change allows a workflow to contain multiple clippy-check
invocations that execute in parallel, by giving each run a unique name.

Previously, any clippy invocations running in parallel would race
against each other, and annotaions would only reported for the first to
hit createCheck(...).

This change allows a workflow to contain multiple clippy-check
invocations that execute in parallel, by giving each run a unique name.

Previously, any clippy invocations running in parallel would race
against each other, and annotaions would only reported for the first to
hit `createCheck(...)`.
@garyttierney
Copy link
Contributor Author

The alternative to this approach is aggregating each clippy-check invocation into a single check run.

There are some problems with this:

  • There needs to be a single invocation responsible for setting the conclusion, this would require tracking pending clippy runs or the user configuring the last invocation in a serial workflow.
  • You would be unable to run multiply clippy invocations in parallel, since they'd still be racing against createCheck(...).
  • Generating summaries for multiple check runs would require fetching the published data from the initial runs and appending on top, or modifying them in some way.

@svartalf
Copy link
Member

I am pretty much okay with this change, but I think it is worth to point that this "input" is a temporary solution for one specific problem and it will be deprecated as soon as Github will implement the Action Annotations.

@svartalf svartalf merged commit 4eb61a7 into actions-rs:master Oct 29, 2019
stefanhp pushed a commit to noveto-com/actions-rs-clippy-check that referenced this pull request Nov 25, 2022
…and_yarn/typescript-eslint/eslint-plugin-5.26.0

Bump @typescript-eslint/eslint-plugin from 5.25.0 to 5.26.0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants