-
-
Notifications
You must be signed in to change notification settings - Fork 94
feature: support multiple targets #62
base: master
Are you sure you want to change the base?
Conversation
|
||
if (opts.targets) { | ||
for (let target of opts.targets) { | ||
await rustup.addTarget(target, opts.name); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if it's safe to run rustup
in parallel? I don't know really if there's any locking or global state...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, rustup is not entirely safe to run concurrently: rust-lang/rustup#988
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Hi, @qmx! Unfortunately, as you said, this is a breaking change and I'm absolutely against merging it in a current state - it will break a lot of CI workflows. It is my mistake not to be clear on the contributing guidelines, so I created the Contributing guide, which also mentions the backwards compatibility and why it matters, I hope that will help us in the future. Regarding your changes, I see a few options:
So far I'm inclined to postpone this change till the |
@svartalf no worries, this was really a conversation starter PR - thanks for taking the time looking at it! |
I just ran into this problem (not being able to specify multiple targets), because I was setting up GitHub actions for an iOS project. Two thoughts:
|
Hi!
I added support multiple target installs on this PR - I am more than happy to accommodate changes to this PR so this gets upstreamed, just let me know.
I know backwards compatibility was broken here, wasn't sure how y'all wanted to handle it - I'm open to implementing whatever strategy is preferred.
Thank you!