Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ability to use the --once flag entirely only allowing --ephemeral to be set #1196

Closed
toast-gear opened this issue Mar 9, 2022 · 2 comments
Closed

Remove the ability to use the --once flag entirely only allowing --ephemeral to be set #1196

toast-gear opened this issue Mar 9, 2022 · 2 comments
Labels
enhancement New feature or request
Milestone
v0.25.0

Comments

@toast-gear
Copy link
Collaborator

toast-gear commented Mar 9, 2022 •
edited
Loading

At the moment you can pick between where your ephemeral runners will be configured witwh the legacy --once flag or the supported new --ephemeral flag. We are not aware of any reason to use the --once flag, the only discussion we've seen on it is here actions/runner#1339 and it is centred around rate limiting which we don't think will be an issue.

We also state in the docs that ARC requires => 3.3 which supports the --ephemeral flag.

If you are running a GHES environment you need to upgrade your GHES instance to => version 3.3 if you wish to maintain an ARC upgrade path and not have down time. In order to remove the --once flag we will need to remove the logic from our runner container [1] [2], this will be done at the point of the linked milestone being released and so if you are using the latest tag or build a custom container from ours you will be impacted effectively at a random time. Migration notes:

  1. Just upgrade to GHES => 3.3 and everything will continue to work (it was released on 07-12-2021)
  2. If you won't / can't you will need to move to persistent runners via setting the attribute ephemeral: false, this will create a significant change in behaviour and so has impacts you may not desire.
  3. Provde your own image from scratch not built from ARC's allowing you to set the --once flag as part of your images entrypoint (don't expect tonnes of help from ARC if you go this direction)

This issue is to be done in the subsequent release to #1189
@toast-gear toast-gear added this to the v0.24.0 milestone Mar 9, 2022
@toast-gear toast-gear added the enhancement New feature or request label Mar 9, 2022
@toast-gear toast-gear pinned this issue Mar 9, 2022
@toast-gear toast-gear mentioned this issue Mar 15, 2022
Closed
mumoshu added a commit that referenced this issue Apr 25, 2022
@mumoshu
runner: Remove the ability to use the deprecated --once flag
0f7cd2b 
Ref #1196
@mumoshu mumoshu mentioned this issue Apr 25, 2022
Merged
mumoshu added a commit that referenced this issue Apr 25, 2022
@mumoshu
runner: Remove the ability to use the deprecated --once flag
1f7f297 
Ref #1196
mumoshu added a commit that referenced this issue Apr 25, 2022
@mumoshu
controller: Stop auto-setting RUNNER_FEATURE_FLAG_EPHEMERAL
969cbe5 
This feature flag was provided from ARC to runner container automatically to let it use `--ephemeral` instead of `--once` by default. As the support for `--once` is being dropped from the runner image via #1384, we no longer need that.

Ref #1196
@mumoshu mumoshu mentioned this issue Apr 25, 2022
Merged
mumoshu added a commit that referenced this issue Apr 25, 2022
@mumoshu
controller: Stop auto-setting RUNNER_FEATURE_FLAG_EPHEMERAL
4c03a3b 
This feature flag was provided from ARC to runner container automatically to let it use `--ephemeral` instead of `--once` by default. As the support for `--once` is being dropped from the runner image via #1384, we no longer need that.

Ref #1196
mumoshu added a commit that referenced this issue Apr 27, 2022
@mumoshu
runner: Ability to opt-out of using --ephemeral
fcd0ca0 
Although we are going to eventually remove the ability to use the legacy --once flag as proposed in #1196, there might be folks still using legacy GHES versions 3.2 or earlier.

This commit removes the existing feature flag to opt-in for --ephemeral, while adding another feature flag RUNNER_FEATURE_FLAG_ONCE to opt-in for --once so that folks stuck in legacy GHES versions
can still use ARC.

Since this change every user starts using --ephemeral by default. If they see any issues on legacy GHES instance, RUNNER_FEATURE_FLAG_ONCE=true can be set to opt-in to keep using --once, which gives one more ARC release until they upgrade their GHES instance.

But beware, we won't support legacy GHES instances forever as it's going to be a maintenance nightmare. Please upgrade!

Ref #1196
toast-gear pushed a commit that referenced this issue May 11, 2022
@mumoshu
refactor(runner): ability to opt-out of using --ephemeral / opt-in to…
c1e5829 
… legacy --once for GHES older than 3.3 (#1384)

* runner: Remove the ability to use the deprecated `--once` flag

Ref #1196

* runner: Ability to opt-out of using --ephemeral

Although we are going to eventually remove the ability to use the legacy --once flag as proposed in #1196, there might be folks still using legacy GHES versions 3.2 or earlier.

This commit removes the existing feature flag to opt-in for --ephemeral, while adding another feature flag RUNNER_FEATURE_FLAG_ONCE to opt-in for --once so that folks stuck in legacy GHES versions
can still use ARC.

Since this change every user starts using --ephemeral by default. If they see any issues on legacy GHES instance, RUNNER_FEATURE_FLAG_ONCE=true can be set to opt-in to keep using --once, which gives one more ARC release until they upgrade their GHES instance.

But beware, we won't support legacy GHES instances forever as it's going to be a maintenance nightmare. Please upgrade!

Ref #1196
toast-gear pushed a commit that referenced this issue May 11, 2022
@mumoshu
refactor(controller): stop auto-setting RUNNER_FEATURE_FLAG_EPHEMERAL (…
dabbc99 
…#1385)

This feature flag was provided from ARC to runner container automatically to let it use `--ephemeral` instead of `--once` by default. As the support for `--once` is being dropped from the runner image via #1384, we no longer need that.

Ref #1196
@toast-gear toast-gear mentioned this issue May 19, 2022
Closed
@mumoshu
Copy link
Collaborator

mumoshu commented May 26, 2022

We ended by making --ephemeral the default and adding the new option to stick with --once instead.
We'll probably leave the new option for a while, but don't expect it to work forever. GitHub Actions and actions/runner may eventually remove the support for --once.
Before they remove it, upgrade to a newer version of GHES, ASAP!

@mumoshu mumoshu closed this as completed May 26, 2022
@mumoshu mumoshu modified the milestones: v0.24.0, v0.25.0 May 27, 2022
@mumoshu
Copy link
Collaborator

mumoshu commented May 27, 2022

Let's keep this open until we completely remove the support for --once.

@mumoshu mumoshu reopened this May 27, 2022
mumoshu added a commit that referenced this issue Jun 29, 2022
@mumoshu
Drop support for --once
08b712d 
Ref #1196
@mumoshu mumoshu mentioned this issue Jun 29, 2022
Merged
mumoshu added a commit that referenced this issue Jun 29, 2022
@mumoshu
Drop support for --once
d652de1 
Ref #1196
mumoshu added a commit that referenced this issue Jun 29, 2022
@mumoshu
Drop support for --once (#1580)
9b28e63 
Ref #1196
@toast-gear toast-gear mentioned this issue Jul 11, 2022
Closed
4 tasks
@toast-gear toast-gear unpinned this issue Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.25.0
Development

No branches or pull requests
2 participants
@mumoshu @toast-gear