Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --no-default-labels runner configuration option #3622

Open
scoplin opened this issue Jun 24, 2024 · 2 comments · May be fixed by #3625
Open

Support --no-default-labels runner configuration option #3622

scoplin opened this issue Jun 24, 2024 · 2 comments · May be fixed by #3625
Labels
community Community contribution enhancement New feature or request needs triage Requires review from the maintainers

Comments

@scoplin
Copy link

scoplin commented Jun 24, 2024

What would you like added?

Support for removing the default labels from a runner was added in actions/runner#2443. This takes the form of an additional flag being passed to config.sh.

It appears that there is precedent for plumbing such options through in the startup.sh script here.

Why is this needed?

I would like to see this option on ARC runners as well. We have some indiscriminate workflows in our organization that use the self-hosted label only and I would like to offer a runner without the default label set, making its use "opt in" without having to make adjustments to many repositories.

I imagine this would also be useful for all the reasons that it was originally added to the runner config.sh script.

Additional context

It was specifically suggested here to open an issue on this project to get this added.

@scoplin scoplin added community Community contribution enhancement New feature or request needs triage Requires review from the maintainers labels Jun 24, 2024
Copy link
Contributor

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

scoplin added a commit to scoplin/actions-runner-controller that referenced this issue Jun 25, 2024
Adds support for passing the `--no-default-labels` flag to `config.sh`.

Resolves actions#3622
@scoplin scoplin linked a pull request Jun 25, 2024 that will close this issue
@scoplin
Copy link
Author

scoplin commented Jun 25, 2024

PR proposed, but of course contingent on agreeing that this is A) a good idea on a legacy runner enhancement and B) the narrow enablement of the single flag is a reasonable approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution enhancement New feature or request needs triage Requires review from the maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant