fix: Pluralize topologySpreadConstraint to match docs

[cbui]

Original PR:
https://github.com/actions-runner-controller/actions-runner-controller/pull/814/files#diff-25283fab3c6d5fa726652c8741a122c1ba14d8486fe092774617a385e4bc1a92R145

Fixes: #984

This is a breaking change for users that have figured out that the field should have been singular.

[mumoshu]

Hey! Thanks for the correction.
Could you instead add a new field so that we can safely remove it in a later version (like v1alpha2)?

[BeyondEvil]

Any updates here? We would like to get this sorted and are happy to help! @cbui @mumoshu

[mumoshu]

@BeyondEvil Hey! It would be great if you could submit another pull request as a successor to this. In that PR code after the change should look like this:

// +optional
TopologySpreadConstraint []corev1.TopologySpreadConstraint `json:"topologySpreadConstraint,omitempty"`

// +optional
TopologySpreadConstraints []corev1.TopologySpreadConstraint `json:"topologySpreadConstraints,omitempty"`

And in our controller we should read topologySpreadConstraint as topologySpreadConstraints(notice the trailing s), by assigning what's in the legacy topologySpreadConstraint to the new topologySpreadConstraints.

[mumoshu]

I discussed with @toast-gear and decided to just make it a breaking change, assuming not everyone uses this feature and ARC is still pre 1.0.
We'll include this change since ARC v0.23.0. Before upgrading, any users of this feature should stop ARC, upgrade CRDs, update RunnerDeployments, and finally upgrade and restart ARC. This way, there will be no downtime for already running workflow jobs.

[mumoshu]

Thanks for your contribution @cbui ☺️

[BeyondEvil]

@BeyondEvil Hey! It would be great if you could submit another pull request as a successor to this. In that PR code after the change should look like this:

// +optional
TopologySpreadConstraint []corev1.TopologySpreadConstraint `json:"topologySpreadConstraint,omitempty"`

// +optional
TopologySpreadConstraints []corev1.TopologySpreadConstraint `json:"topologySpreadConstraints,omitempty"`

And in our controller we should read topologySpreadConstraint as topologySpreadConstraints(notice the trailing s), by assigning what's in the legacy topologySpreadConstraint to the new topologySpreadConstraints.

Hey @mumoshu

Do you still need these changes? If so, I might be able to get them done today.