Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: add linux arm/v7/v8 support #1120

Closed
wants to merge 1 commit into from

Conversation

cpanato
Copy link
Contributor

@cpanato cpanato commented Feb 16, 2022

  • images: add linux arm/v7/v8 support

Fixes: #1104

cc @mumoshu

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@cpanato
Copy link
Contributor Author

cpanato commented Feb 16, 2022

looks like this dependency does not have the arm available https://github.com/Yelp/dumb-init

@cpanato
Copy link
Contributor Author

cpanato commented Feb 16, 2022

i will try to build locally, found other places that I was not aware when open this pr

@cpanato
Copy link
Contributor Author

cpanato commented Feb 16, 2022

@mumoshu if the dumb-init is required, I think we will need to close this pr because that does not have the arm support and the underlining dependencies for that also does not have (for context pypa/manylinux#84) so will take some time :/

@mumoshu
Copy link
Collaborator

mumoshu commented Feb 16, 2022

@cpanato Ah, good catch! I believe we don't have a strict requirement to stick with dumb-init. I thought there was a similar open source project that is written in Golang. IMHO a Golang-written alternative would have a better story on cross-platform.

@mumoshu
Copy link
Collaborator

mumoshu commented Feb 16, 2022

@toast-gear has suggested using tini instead, and I think it's great!
The only gotcha would be that we need to pass -g to tini to make it compatible with our usage(and the default behavior of dumb-init)

https://github.com/Yelp/dumb-init#session-behavior
https://github.com/krallin/tini#process-group-killing

@cpanato
Copy link
Contributor Author

cpanato commented Feb 21, 2022

sounds good! this is something you want to change and you want this in the project?

i will close this pr for now, thanks for all the support! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more linux archs to the image
2 participants