Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build-runner workflow to be compatible with forks, fix image push #117

Merged
merged 5 commits into from
Oct 13, 2020

Conversation

jnewland
Copy link
Contributor

@jnewland jnewland commented Oct 12, 2020

A follow-up to #115 that replaces the hardcoded summerwind portion of the image name with ${{ github.repository_owner }} to enable contributors to test the image pushing behavior and fixes image building by conditionally passing --push to the build step based on the event that triggered the workflow.

After setting the DOCKER_ACCESS_TOKEN Secret on my fork of this repository, I was able to use this updated workflow to build and push a set of images and confirm their functionality. I imagine this will be useful to future contributors who wish to help with the chore of keeping up with https://github.com/actions/runner/releases. 😅

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Thanks for the awesome work @jnewland ☺️

@mumoshu mumoshu merged commit 231cde1 into actions:master Oct 13, 2020
@jnewland jnewland mentioned this pull request Oct 13, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants