Fix runner pod dnsConfig

[billimek]

... this may be missing based on details from this issue

Fixes #1226
Fixes #1224

[billimek]

I've been unable to build this as a docker container against the Makefile/Dockerfile in the master branch due to strange errors that occur on MacOS, a linux VM, and even github codespaces all with the same error about a read-only filesystem:

RUN --mount=target=.   --mount=type=cache,mode=0777,target=${GOCACHE}   export GOOS=${TARGETOS} GOARCH=${TARGETARCH} GOARM=${TARGETVARIANT#v} &&   go build -o /out/manager main.go &&   go build -o /out/github-webhook-server ./cmd/githubwebhookserver:                                           
#13 0.428 container_linux.go:380: starting container process caused: process_linux.go:545: container init caused: rootfs_linux.go:75: mounting "/var/lib/docker/overlay2/ygto3kzjlp7rm7fq3guf88gdb/merged/cache" to rootfs at "/workspace/${GOCACHE}" caused: mkdir /var/lib/docker/buildkit/executor/cncbc4ch5a1h2ysgmn7zb8i3v/rootfs/workspace/${GOCACHE}: read-only file system

However, I was able to apply the changes and build against the Makefile/Dockerfile based off of the code in the v0.21.1 tag. Using this, and the associated built and pushed actions-runner-controller docker image (billimek/actions-runner-controller:dnsConfig-b25a0fd6) & changed CRDs, I was able to successfully run and apply the dnsConfig in my actions-runner-controller environment

[splitice]

I've also got a similar issue trying to build (linux docker)

[billimek]

I think I sorted the local build issues by using the make docker-buildx (vs make docker-build).

We've been running the backported fix now in our org-wide runners without issue and would love to see what next steps are necessary to progress this PR?

[toast-gear]

We need to do some testing and can merged. v0.23.x was on hold until we resolved any regressions and bugs born from the v0.22.x codebase. v0.22.0 was a major architectural change so we froze non-essential merges until the codebase was solid. We're going to start working towards getting everything merged for v0.23.0.

@billimek can you raise an issue for the controller build on a Mac including details and when it broke, perhaps go back through the history of the controller Dockerfile and see when it stopped building?

[toast-gear]

Have you actually tried installing this? Haven't digged into it yet but I get the below error when trying to install your branch's chart:

Error: failed to install CRD crds/actions.summerwind.dev_runnerreplicasets.yaml: CustomResourceDefinition in 
version "v1" cannot be handled as a CustomResourceDefinition: v1.CustomResourceDefinition.Spec: v1.CustomResourceDefinitionSpec.Versions: []v1.CustomResourceDefinitionVersion: 
v1.CustomResourceDefinitionVersion.Schema: v1.CustomResourceValidation.OpenAPIV3Schema: v1.JSONSchemaProps.Properties: v1.JSONSchemaProps.Properties: v1.JSONSchemaProps.Properties: 
v1.JSONSchemaProps.Properties: v1.JSONSchemaProps.Properties: readObjectStart: expect { or n, but 
found ", error found in #10 byte of ...|},"type":"object"},"|..., bigger context ...|items":
{"type":"string"},"type":"array"}},"type":"object"},"type":"array"},"dockerEnabled":{"type":"|...

EDIT regenerating the manifests fixes it, @billimek can you regenerate them make manifest, commit them, test it works and comment back when done?

[billimek]

I think the latest merge from master requires an additional generation of the replica set CRD. I know what to do. Will push a working update today.

FWIW we are running these changes "in prod" everywhere now without issue. Can't wait to eventually go back to the official image & code!

[billimek]

@toast-gear this is done - FYI the make manifest operation did create some changes in the config/crd/bases which I assume is also expected.

[mumoshu]

LGTM. Thanks a lot for your contribution @billimek ☺️