Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed Runner Dockerfiles #1248

Merged
merged 1 commit into from
May 16, 2022
Merged

Renamed Runner Dockerfiles #1248

merged 1 commit into from
May 16, 2022

Conversation

Fleshgrinder
Copy link
Contributor

Renamed the runner dockerfiles so that we have proper syntax highlighting for them, as well as a consistent way to map from the image name to the dockerfile. Added a .dockerignore file to avoid uploading things to the daemon that we never use.

Copy link
Collaborator

@toast-gear toast-gear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @Fleshgrinder resolve the conflicts and we can merge this

@Fleshgrinder
Copy link
Contributor Author

@toast-gear done

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution ☺️

Renamed the runner dockerfiles so that we have proper syntax highlighting for them, as well as a consistent way to map from the image name to the dockerfile. Added a `.dockerignore` file to avoid uploading things to the daemon that we never use.
@mumoshu
Copy link
Collaborator

mumoshu commented May 16, 2022

(Re-resolved the conflict and waiting for the CI to pass...

@mumoshu mumoshu merged commit cdc9d20 into actions:master May 16, 2022
@Fleshgrinder Fleshgrinder deleted the dockerfile branch May 16, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants