Remove the default githubEvent: {} requiring a event to be defined
#1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumoshu
force-pushed
the
require-explicit-config-for-workflow-job-scale
branch
2 times, most recently
from
3bb0038
to
3885401
Compare
mumoshu
force-pushed
the
require-explicit-config-for-workflow-job-scale
branch
from
3885401
to
e284160
Compare
mumoshu
pushed a commit
that referenced
this pull request
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#922 enahnced the API to accept
workflowJob: {}under the githubEvent field. But we had not enhanced the autoscaler code to actually read it to toggle the workflow-job-based scaling. This adds that.Ref #1358
See also #1361