Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart): add missing namespace to webhook.ingress #1417

Merged
merged 1 commit into from
May 15, 2022

Conversation

maigl
Copy link
Contributor

@maigl maigl commented May 6, 2022

I think I found a small bug:
When deploying the helm chart with:

helm template --namespace 'my-runner-namespace' ... | kubectl apply -f -

the ingress of the webhook server is deployed into namespace default instead
of my-runner-namespace. All other resources seem to be deployed into the correct namespace.

proposed fix:
The ingress needs to be deployed in the very same namespace as the service it is forwarding to.

Michael Kuhnt michael.kuhnt@mercedes-benz.com Mercedes-Benz Tech Innovation GmbH (ProviderInformation)

The ingress needs to be deployed in the very same namespace
as the service it is forwarding to.
@maigl maigl marked this pull request as ready for review May 6, 2022 14:57
@toast-gear toast-gear added this to the v0.24.0 milestone May 12, 2022
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for fixing it!

@mumoshu mumoshu merged commit 81017b1 into actions:master May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants