Commits on Jan 23, 2023

1. chore(deps): bump sigs.k8s.io/controller-runtime from 0.13.1 to 0.14.1 …

   Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.13.1 to 0.14.1.
   - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
   - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/master/RELEASE.md)
   - [Commits](kubernetes-sigs/controller-runtime@v0.13.1...v0.14.1)
   
   ---
   updated-dependencies:
   - dependency-name: sigs.k8s.io/controller-runtime
     dependency-type: direct:production
     update-type: version-update:semver-minor
   ...
   
   Signed-off-by: dependabot[bot] <support@github.com>

   

   dependabot[bot] authored and mumoshu committed Jan 23, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for c7e264a
   • Browse repository at this point

   Copy the full SHA

   c7e264a View commit details

   Browse the repository at this point in the history

2. Update CRDs with the newer K8s version with workaround for controller… …

   …-gen issue

   

   mumoshu committed Jan 23, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 936a89a
   • Browse repository at this point

   Copy the full SHA

   936a89a View commit details

   Browse the repository at this point in the history

3. Bump to ginkgo v2 so that it works with the newer controller-runtime

   

   mumoshu committed Jan 23, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 1623a23
   • Browse repository at this point

   Copy the full SHA

   1623a23 View commit details

   Browse the repository at this point in the history

4. Update status patcher util and interface for newer controller-runtime… …

   … compatibiility

   

   mumoshu committed Jan 23, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 1b61488
   • Browse repository at this point

   Copy the full SHA

   1b61488 View commit details

   Browse the repository at this point in the history

5. Fix failing test due to the fake client indexer change in the new con… …

   …troller-runtime
   
   controller-runtime 0.14 includes kubernetes-sigs/controller-runtime#2025 which turned out to be a breaking change for any tests that use fake controller-runtime client for list operations against the index.
   
   This commit addresses that, by extracting the indexer func out of the reconciler setup function so that both the reconciler setup func and the set-only fake client setup func can use the same indexer func.
   
   This fixes integration errors like the below example:
   
   ```
   --- FAIL: TestWebhookWorkflowJobWithSelfHostedLabel (0.00s)
       --- FAIL: TestWebhookWorkflowJobWithSelfHostedLabel/Successful (0.00s)
           horizontal_runner_autoscaler_webhook_test.go:256: status: 500
           horizontal_runner_autoscaler_webhook_test.go:256: body: List on GroupVersionKind actions.summerwind.dev/v1alpha1, Kind=HorizontalRunnerAutoscaler specifies selector on field scaleTarget, but no index with name scaleTarget has been registered for GroupVersionKind actions.summerwind.dev/v1alpha1, Kind=HorizontalRunnerAutoscaler
           horizontal_runner_autoscaler_webhook_test.go:440: diagnostics: testlog] finding repository-wide runnerrepository.name=MYREPO repository.owner.login=MYORG repository.owner.type=Organization action=queued delivery= workflowJob.labels=[self-hosted label1] workflowJob.status=queued enterprise.slug= workflowJob.runID=1234567890 workflowJob.ID=1234567890 event=workflow_job hookID= repository=MYORG/MYREPO error=List on GroupVersionKind actions.summerwind.dev/v1alpha1, Kind=HorizontalRunnerAutoscaler specifies selector on field scaleTarget, but no index with name scaleTarget has been registered for GroupVersionKind actions.summerwind.dev/v1alpha1, Kind=HorizontalRunnerAutoscaler
               testlog] handling check_run eventevent=workflow_job hookID= workflowJob.status=queued enterprise.slug= workflowJob.runID=1234567890 workflowJob.ID=1234567890 delivery= workflowJob.labels=[self-hosted label1] repository.name=MYREPO repository.owner.login=MYORG repository.owner.type=Organization action=queued error=List on GroupVersionKind actions.summerwind.dev/v1alpha1, Kind=HorizontalRunnerAutoscaler specifies selector on field scaleTarget, but no index with name scaleTarget has been registered for GroupVersionKind actions.summerwind.dev/v1alpha1, Kind=HorizontalRunnerAutoscaler
   ```
   
   Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>

   

   mumoshu committed Jan 23, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for ade9ccd
   • Browse repository at this point

   Copy the full SHA

   ade9ccd View commit details

   Browse the repository at this point in the history