Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error for non-existing runner group. #2215

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

TingluoHuang
Copy link
Member

The controller currently crashes when you provide a non-existing runner group.
image

https://github.com/github/c2c-actions-runtime/issues/2268

rentziass
rentziass previously approved these changes Jan 26, 2023
Copy link
Member

@rentziass rentziass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a question about testing retries

@TingluoHuang TingluoHuang merged commit b09e3a2 into master Jan 26, 2023
@TingluoHuang TingluoHuang deleted the users/tihuang/fixrunnergroup branch January 26, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants