Add new workflow to automate runner updates #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rentziass
requested review from
mumoshu,
toast-gear,
a team and
nikola-jokic
as code owners
Link-
reviewed
Feb 3, 2023
Link-
requested changes
Feb 3, 2023
nikola-jokic
previously approved these changes
Feb 3, 2023
Link-
reviewed
Feb 3, 2023
Link-
reviewed
Feb 3, 2023
Link-
reviewed
Feb 3, 2023
Link-
previously approved these changes
Feb 3, 2023
nikola-jokic
reviewed
Feb 3, 2023
nikola-jokic
reviewed
Feb 3, 2023
Co-authored-by: Nikola Jokic <jokicnikola07@gmail.com>
nikola-jokic
approved these changes
Feb 3, 2023
Link-
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New workflow:
update-runnersThis adds a new workflow that polls actions/runner releases hourly, and in case there is a new version will open a pull request that, if merged, will trigger the usual
release-runnersworkflow. The PR will contain changes to:runner/VERSIONrunner/MakefileMakefiletest/e2e/e2e_test.goChanges to
release-runnersand existing Dockerfilesrelease-runnershas been changed to read its runner version fromrunner/VERSION: this is because automating a workflow definition requires a special PAT withworkflowpermission. As a side effect this also makes version changes a bit more "intentional" imo.This is also removing default values for
RUNNER_VERSIONfrom the various Dockerfiles as we're providing this as build args anyway.Below is a sample screenshots of what the automated PR will look like:
