-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate runner scale set name annotation to EphemeralRunner #3098
Propagate runner scale set name annotation to EphemeralRunner #3098
Conversation
Hey @ordovicia, Can you please help me understand what problem does this PR solve? We already have a label that specifies the scale set name. |
Yes, EphemeralRunner resources already have
Runner scale set name can be different from AutoscalingRunnerSet name when the user specifies actions-runner-controller/controllers/actions.github.com/autoscalingrunnerset_controller.go Lines 445 to 446 in 7793e19
So, to resolve the runner scale set name for an EphemeralRunner, users need to first get its parent AutoscalingRunnerSet, and then read the AutoscalingRunnerSet's |
Hi @nikola-jokic could you please take a look at my comment above? Thank you! |
Hey @ordovicia, Sorry for the delay and thank you for the explanation. I don't think adding an annotation is the right approach here. If the purpose of the field is to query it, it should be a label. Also, we use annotations mostly to include some metadata, so they should be completely scoped to the cluster resources. |
Thank you @nikola-jokic for the reply! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you and sorry for the delay!
With this PR, AutoscalingRunnerSets' annotation that describes its runner scale set name will be propagated to EphemeralRunners.
This change would make it easy to inspect EphemeralRunners for troubleshooting.
This PR changes
runner-scale-set-name
annotation key toactions.github.com/runner-scale-set-name
to align it withactions.github.com/runner-group-name
.The annotation is used only inside the controllers, but I am not sure if this change is acceptable.