Expose volumeMounts and volumes in gha-runner-scale-set-controller #3260
Conversation
My team needs to be able to mount our cert chain into these containers so they can trust our GHE deployment certs.
taliastocks
requested review from
mumoshu,
toast-gear,
nikola-jokic and
a team
as code owners
| @@ -110,10 +110,16 @@ spec: | |||
| volumeMounts: | |||
| - mountPath: /tmp | |||
| name: tmp | |||
| {{- range .Values.volumeMounts }} | |||
| - {{ toJson . }} | |||
There was a problem hiding this comment.
Can you please use toYaml? When someone renders a chart, it would be much easier to read
There was a problem hiding this comment.
Yes, I can do that. Thanks for the review.
You probably want me to add to Do you have instructions somewhere on running these tests? It doesn't look like there's a Github Action enabled (somewhat ironically). |
|
Yeah, so to run tests, you do |
add test to volumes and volumeMounts options
Thank you! That is fair, security is important. |
|
Tests are updated and passing. |
nikola-jokic
added
the
gha-runner-scale-set
nikola-jokic
modified the milestones:
gha-runner-scale-set-0.9.0,
gha-runner-scale-set-0.8.3
My team needs to be able to mount our cert chain into these containers so they can trust our GHE deployment certs.