Add retry on 401 and 403 for runner-registration #3377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikola-jokic
requested review from
mumoshu,
toast-gear,
rentziass and
a team
as code owners
nikola-jokic
force-pushed
the
nikola-jokic/retry-on-4xx
branch
from
77d4eba
to
d8c3355
Compare
nikola-jokic
changed the title
nikola-jokic
added
the
gha-runner-scale-set
rentziass
reviewed
Mar 26, 2024
github/actions/client.go
Outdated
| if retry > 3 { | ||
| return nil, fmt.Errorf("unable to register runner after 3 retries: %v", err) | ||
| } | ||
| time.Sleep(1 * time.Second) |
There was a problem hiding this comment.
Should we use a growing interval here? e.g. 250 * time.Millisecond * (retries + 1) or something like that?
github/actions/client.go
Outdated
Comment on lines
987
to
992
| var actionsServiceAdminConnection *ActionsServiceAdminConnection | ||
| if err := json.NewDecoder(resp.Body).Decode(&actionsServiceAdminConnection); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return actionsServiceAdminConnection, nil |
There was a problem hiding this comment.
Can we move handling the happy path out of the loop? I think the goal of the loop should be to handle retryable errors?
| } | ||
| defer resp.Body.Close() | ||
| retry := 0 | ||
| for { |
There was a problem hiding this comment.
This might be painful because this is unexported, but can we add a test for this?
There was a problem hiding this comment.
Added, good call!
Co-authored-by: Francesco Renzi <rentziass@gmail.com>
rentziass
approved these changes
Mar 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.