Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add topologySpreadConstraint to gha-runner-scale-set-controller chart #3405

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Add topologySpreadConstraint to gha-runner-scale-set-controller chart #3405

merged 3 commits into from
Apr 12, 2024

Conversation

DaazKu
Copy link
Contributor

@DaazKu DaazKu commented Apr 4, 2024 •
edited
Loading

Adds topologySpreadConstraint to gha-runner-scale-set-controller so that we can spread replicas across AZs like so:

topologySpreadConstraints:
  - labelSelector:
      matchLabels:
        app.kubernetes.io/name: gha-rs-controller # Or "nameOverride" if defined
    maxSkew: 1
    topologyKey: topology.kubernetes.io/zone
    whenUnsatisfiable: DoNotSchedule

Reference: https://kubernetes.io/docs/concepts/scheduling-eviction/topology-spread-constraints/

@DaazKu DaazKu force-pushed the chart-gha-rssc-topologyspreaconstraint branch from 9971251 to 5e68aa8 Compare April 4, 2024 14:43
@DaazKu DaazKu marked this pull request as ready for review April 4, 2024 14:48
nikola-jokic
nikola-jokic suggested changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@nikola-jokic nikola-jokic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run go fmt ☺️

charts/gha-runner-scale-set-controller/values.yaml Outdated Show resolved Hide resolved
@nikola-jokic nikola-jokic added the gha-runner-scale-set Related to the gha-runner-scale-set mode label Apr 8, 2024
@DaazKu DaazKu force-pushed the chart-gha-rssc-topologyspreaconstraint branch from 53912dc to 846a17d Compare April 8, 2024 12:59
@DaazKu DaazKu requested a review from nikola-jokic April 8, 2024 13:00
nikola-jokic
nikola-jokic approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@nikola-jokic nikola-jokic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nikola-jokic nikola-jokic merged commit 0006dd5 into actions:master Apr 12, 2024
16 checks passed
@nikola-jokic nikola-jokic mentioned this pull request Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikola-jokic nikola-jokic nikola-jokic approved these changes

@mumoshu mumoshu Awaiting requested review from mumoshu mumoshu is a code owner

@toast-gear toast-gear Awaiting requested review from toast-gear toast-gear is a code owner

@rentziass rentziass Awaiting requested review from rentziass rentziass is a code owner

Assignees
No one assigned
Labels
gha-runner-scale-set Related to the gha-runner-scale-set mode
Projects
None yet
Milestone
gha-runner-scale-set-0.9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@DaazKu @nikola-jokic