Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check status code of fetch access token for github app #3568

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

nikola-jokic
Copy link
Contributor

Previously, the status code was not checked on fetchAccessToken.

This PR aims to add a check for the endpoint described here.

Fixes #3565

@nikola-jokic nikola-jokic added the gha-runner-scale-set Related to the gha-runner-scale-set mode label Jun 3, 2024
@kahirokunn
Copy link
Contributor

LGTM

@nikola-jokic nikola-jokic merged commit b2c6992 into master Jun 21, 2024
16 checks passed
@nikola-jokic nikola-jokic deleted the nikola-jokic/check-access-token-resp-code branch June 21, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gha-runner-scale-set Related to the gha-runner-scale-set mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading logs when blocked by IP allow list, does not show failure when requesting access token
3 participants