Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: add example for monitoring the github runner #671

Closed
wants to merge 1 commit into from

Conversation

Mic92
Copy link

@Mic92 Mic92 commented Jun 30, 2021

No description provided.

@peimanja
Copy link

peimanja commented Jul 1, 2021

Does it makes sense for controller to also get these metrics and expose them? or is that considered out of scope?

@Mic92
Copy link
Author

Mic92 commented Jul 1, 2021

I would use them if they were available. But I also see value in asking github directly.

@toast-gear
Copy link
Collaborator

toast-gear commented Jul 3, 2021

Thanks for the work however we aren't going to merge this PR unfortunately. The PR isn't very related to the project really beyond the fact it monitors an API we happen to consume. There are millions of tools and if we try to document all of them the documentation will very quickly become out of date, incorrect and unusable and so it just isn't possible. Additionally, every tool we add to the documentation is a tool we need to test between releases of the project as well as releases of the tool itself too.

Does it makes sense for controller to also get these metrics and expose them? or is that considered out of scope?

It's out of scope for now, this really is something GitHub need to resolve with their Actions offering. There is an issue about observability which they really need to look into actions/runner#1116. Please thumbs up and / or comment on this issue as it's a major shortcoming of the product offering atm and certainly is something that is a problem in my environment so I too would very much like this resolved!

@Mic92
Copy link
Author

Mic92 commented Jul 3, 2021

I trust telegraf configuration to be more stable than your project to be honest.

@Mic92 Mic92 closed this Jul 3, 2021
@Mic92
Copy link
Author

Mic92 commented Jul 3, 2021

Drop it here: actions/runner#1184

@Mic92 Mic92 deleted the monitoring branch July 3, 2021 17:29
@toast-gear
Copy link
Collaborator

toast-gear commented Jul 23, 2021

https://github.com/Spendesk/github-actions-exporter for posterity's sake I thought I'd add this here. I just found this project which tackles the observability issues around runners as well as the workflows themselves. Haven't had a chance to test it yet but it looks promising and a much more appropriate project to be tackling this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants