Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow GH priv key from env in helm chart #884

Merged
merged 6 commits into from
Dec 14, 2021
Merged

fix: allow GH priv key from env in helm chart #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
078741f
fix: allow GH priv key from env in helm chart
apr-1985 Oct 12, 2021
23343b6
Merge branch 'master' into priv_key_from_env
apr-1985 Oct 18, 2021
e59fbd0
Update charts/actions-runner-controller/templates/deployment.yaml
mumoshu Dec 14, 2021
ba51081
Merge branch 'master' into priv_key_from_env
mumoshu Dec 14, 2021
2c60bef
Update charts/actions-runner-controller/values.yaml
mumoshu Dec 14, 2021
49bd134
Update charts/actions-runner-controller/values.yaml
mumoshu Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion charts/actions-runner-controller/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,11 @@ spec:
name: {{ include "actions-runner-controller.secretName" . }}
optional: true
- name: GITHUB_APP_PRIVATE_KEY
value: /etc/actions-runner-controller/github_app_private_key
valueFrom:
secretKeyRef:
key: github_app_private_key
name: {{ include "actions-runner-controller.secretName" . }}
optional: true
{{- end }}
{{- range $key, $val := .Values.env }}
- name: {{ $key }}
Expand Down
6 changes: 6 additions & 0 deletions charts/actions-runner-controller/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ enableLeaderElection: true

# Only 1 authentication method can be deployed at a time
# Uncomment the configuration you are applying and fill in the details
#
# If authSecret.enabled=true these values are inherited to actions-runner-controller's controller-manager container's env.
#
# Do set authSecret.enabled=false and set env if you want full control over
# the GitHub authn related envvars of the container.
# See https://github.com/actions-runner-controller/actions-runner-controller/pull/937 for more details.
authSecret:
enabled: true
create: false
Expand Down