Skip to content

Commit

Permalink
set @types/node version to latest v16 release (#373)
Browse files Browse the repository at this point in the history
* set @types/node version to latest v16 release

* upgrade workflow to install Node 16

* update tsconfig to use es2015 target and libraries

* pin to actual latest v16 package of @types/node
  • Loading branch information
shiftkey committed May 8, 2023
1 parent 23e1389 commit 7c06a2e
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 12 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/check-dist.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ jobs:
steps:
- uses: actions/checkout@v3

- name: Set Node.js 12.x
- name: Set Node.js 16.x
uses: actions/setup-node@v3
with:
node-version: 12.x
node-version: 16.x
cache: npm

- name: Install dependencies
Expand Down
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"devDependencies": {
"@github/prettier-config": "^0.0.6",
"@types/jest": "^27.5.0",
"@types/node": "~16.18.25",
"@types/node": "16.18.26",
"@typescript-eslint/parser": "^5.59.2",
"@vercel/ncc": "^0.36.1",
"concurrently": "^8.0.1",
Expand Down
5 changes: 3 additions & 2 deletions tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
{
"compilerOptions": {
"target": "es6" /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019' or 'ESNEXT'. */,
"target": "ES2015" /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019' or 'ESNEXT'. */,
"module": "commonjs" /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */,
"outDir": "./lib" /* Redirect output structure to the directory. */,
"rootDir": "./src" /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */,
"strict": true /* Enable all strict type-checking options. */,
"noImplicitAny": true /* Raise error on expressions and declarations with an implied 'any' type. */,
"esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */,
"noUncheckedIndexedAccess": true
"noUncheckedIndexedAccess": true,
"lib": ["ES2015"]
},
"exclude": ["node_modules", "**/*.test.ts"]
}

0 comments on commit 7c06a2e

Please sign in to comment.