Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Action to use new ProjectsV2 api #105

Merged
merged 12 commits into from
Jun 28, 2022

Conversation

lukewar
Copy link
Contributor

@lukewar lukewar commented May 19, 2022

Currently beta ProjectNext API is going to be deprecated soon. Is is being replaced with new ProjectV2 API.

In this PR I am updating add-to-project action to use new ProjectV2 API.

ProjectsNext API is going to be deprecated in favour of new ProjectsV2.
Remove feature flags header as it will not be needed after API is released.
@lukewar
Copy link
Contributor Author

lukewar commented Jun 2, 2022

I have update the Readme and removed reference from @main branch in the examples since we make releases now. I have also removed the section How to point the action to a specific branch or commit sha for the same reason.

@mattcosta7 WDYT about making 0.1.0 release when merge those changes?

@lukewar lukewar marked this pull request as ready for review June 2, 2022 15:33
@lukewar lukewar requested a review from a team as a code owner June 2, 2022 15:33
@mattcosta7
Copy link
Contributor

@lukewar @ekroon - conflicts on the built output, after landing a few updates here.

When are we planning to push this one forward?

@ekroon
Copy link

ekroon commented Jun 24, 2022

@lukewar @ekroon - conflicts on the built output, after landing a few updates here.

When are we planning to push this one forward?

We have removed the feature flag for the new API yesterday, so we can move forward with this now.

Copy link
Contributor

@Mattamorphic Mattamorphic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We updated the addProjectV2ItemById mutation to return a item field instead of projectItem to align with other call sites across the ProjectV2 mutations and objects.

__tests__/add-to-project.test.ts Outdated Show resolved Hide resolved
__tests__/add-to-project.test.ts Outdated Show resolved Hide resolved
__tests__/add-to-project.test.ts Outdated Show resolved Hide resolved
__tests__/add-to-project.test.ts Outdated Show resolved Hide resolved
__tests__/add-to-project.test.ts Outdated Show resolved Hide resolved
__tests__/add-to-project.test.ts Outdated Show resolved Hide resolved
__tests__/add-to-project.test.ts Outdated Show resolved Hide resolved
src/add-to-project.ts Outdated Show resolved Hide resolved
src/add-to-project.ts Outdated Show resolved Hide resolved
src/add-to-project.ts Outdated Show resolved Hide resolved
@lukewar
Copy link
Contributor Author

lukewar commented Jun 27, 2022

Tested recent changes 💯.

CleanShot 2022-06-27 at 18 03 27@2x

Last action's failure is expected because I have changed the scope to insufficient level.

@mattcosta7
Copy link
Contributor

Are the docs here still correct - or can they be updated as well to account for the new project scoped tokens?

https://github.com/actions/add-to-project#inputs

specifically around the scopes necessary for this token

@lukewar
Copy link
Contributor Author

lukewar commented Jun 28, 2022

Are the docs here still correct - or can they be updated as well to account for the new project scoped tokens?

https://github.com/actions/add-to-project#inputs

specifically around the scopes necessary for this token

Thanks for asking. It was updated, but your comment made me double check and it wasn't updated in all places. 🙇

@lukewar lukewar merged commit 2b841e5 into actions:main Jun 28, 2022
@lukewar lukewar deleted the graphql/projectv2 branch June 28, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants