Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new option for excluding issues with certain labels #130

Merged
merged 10 commits into from
Jun 17, 2022

Conversation

AnthonyLaye
Copy link
Contributor

@AnthonyLaye AnthonyLaye commented Jun 16, 2022

What are you trying to accomplish?

Suggestion for a way to exclude issues with certain labels from being added to a project board.

There is currently support for listing labels and deciding the operator used for filtering (AND / OR). This PR adds a new operator, NOT, which creates the possibility to only add the issue to the project board if none of the listed labels are present in the issue. I added tests to verify functionality, and updated the readme with an example.

Anything you want to highlight for special attention from reviewers?

Syntax. I'm not too familiar with TS and I didn't know how to run/compile my changes to make sure that they work. I ran my new tests with npm run test and it seems to have passed though.

@AnthonyLaye AnthonyLaye marked this pull request as ready for review June 16, 2022 16:07
@AnthonyLaye AnthonyLaye requested a review from a team as a code owner June 16, 2022 16:07
@mattcosta7
Copy link
Contributor

@AnthonyLaye thanks for the contributions here!

Actions need to have their built code in the repo (there's a check for this that fails currently), which you should be able to fix with an npm run build, then checkin the changes

@mattcosta7
Copy link
Contributor

There are some details in the readme about the label-operator. would you mind updated those to include the new option?

@AnthonyLaye
Copy link
Contributor Author

I can include an example in the readme on how to use the NOT operator tomorrow

@mattcosta7
Copy link
Contributor

@AnthonyLaye this should be good to merge, once you checkin the built code by running npm run build again and committing that, thanks!

@mattcosta7 mattcosta7 merged commit 69f6549 into actions:main Jun 17, 2022
@mattcosta7
Copy link
Contributor

published in v0.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants