Perform case-insensitive comparison #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akashivskyy thanks for the fix here! looks good - happy to merge and cut a version for this. Would you mind running |
|
@mattcosta7 Done! |
mattcosta7
approved these changes
Jun 22, 2022
|
shipped in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 👋 Labels are case-insensitive, so the checks done by this action must take that into account. I encountered this issue when I configured this action to detect
ioslabel in my repository, but since the actual label name isiOS, it got ignored.This PR fixes this issue by transforming labels to lowercase before comparing them. The added test fails before the change and passes after the change.