Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tests to account for api change #143

Merged
merged 1 commit into from
Jun 30, 2022
Merged

fix tests to account for api change #143

merged 1 commit into from
Jun 30, 2022

Conversation

mattcosta7
Copy link
Contributor

@mattcosta7 mattcosta7 commented Jun 30, 2022 •
edited
Loading

A test was not accounted for in a recent pr, that was opened before the code merged. this should fix that, and ensure that npm run test is executed in workflows

fixes #140
fixes #141

@mattcosta7 mattcosta7 requested a review from a team as a code owner June 30, 2022 13:14
@mattcosta7 mattcosta7 self-assigned this Jun 30, 2022
shiftkey
shiftkey approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the swift PR @mattcosta7!

@mattcosta7 mattcosta7 merged commit 5d3a082 into main Jun 30, 2022
@mattcosta7 mattcosta7 deleted the fix-tests branch June 30, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftkey shiftkey shiftkey approved these changes

Assignees

@mattcosta7 mattcosta7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests are not run in CI on push Failing tests on the main branch
2 participants
@mattcosta7 @shiftkey