GHES support. Allow projects outside github.com #210
Conversation
| @@ -4,7 +4,7 @@ import * as github from '@actions/github' | |||
| // TODO: Ensure this (and the Octokit client) works for non-git.luolix.top URLs, as well. | |||
| // https://github.com/orgs|users/<ownerName>/projects/<projectNumber> | |||
| const urlParse = | |||
| /^(?:https:\/\/)?github\.com\/(?<ownerType>orgs|users)\/(?<ownerName>[^/]+)\/projects\/(?<projectNumber>\d+)/ | |||
| /^(?:https:\/\/)?[^/]+\/(?<ownerType>orgs|users)\/(?<ownerName>[^/]+)\/projects\/(?<projectNumber>\d+)/ | |||
There was a problem hiding this comment.
The (?:https:\/\/)?[^/]+ part of this expression seems like it could be buggy. If the URL protocol is https:// it will work fine, but if it's anything else (like http://), the first group will pass because it's optional and then the [^/] part will unexpectedly stop at the first forward-slash, which will be in the protocol.
Maybe we shouldn't have a 'beginning-of-string' part of the regex at all? It doesn't seem to really matter what goes before or after the part of the URL we care about. That seems like it would allow us to make a more robust regex that just searches anywhere in the string for a /orgs/*/projects/* match:
\/(?<ownerType>orgs|users)\/(?<ownerName>[^/]+)\/projects\/(?<projectNumber>\d+)
There was a problem hiding this comment.
@iansan5653 Anyway I got an answer that this action not working with GHES. But this change will be needed 100% :)
There was a problem hiding this comment.
Oh right, I forgot the new Projects hasn't shipped to GHES yet 😄
I'm going to close this PR for now but we can revisit & reopen it once that's shipped
I'm trying to use this action on GHES, and I see there's a strict URL match for github.com projects though the domain isn't use thereafter.