Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that filter doesn't override fetch-depth #1505

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jakebailey
Copy link

As noted in #1396 (comment), if you want to make full use of filter: blob:none, you still need to set fetch-depth: 0, as the default is still 1 which means you still don't get any history.

Happy to change this to whatever makes sense.

@jakebailey jakebailey requested a review from a team as a code owner October 5, 2023 16:05
@jenseng
Copy link

jenseng commented Oct 24, 2023

Or perhaps if a filter is set, fetch-depth could then implicitly default to 0? I can't think of a scenario where you'd want a simultaneously shallow AND partial clone.

edit: fixed 1 -> 0 😆

@jakebailey
Copy link
Author

I assume you mean "default to 0", but yeah, that was something I thought about too, I just wasn't sure how much of a breaking change was palatable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants