Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explanatory comment to plugin #31

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Add explanatory comment to plugin #31

merged 1 commit into from
Sep 6, 2019

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Sep 6, 2019

@thboop to review. Once this is in we should do the same in upload/download artifact

@damccorm
Copy link
Contributor Author

damccorm commented Sep 6, 2019 •
edited
Loading

See actions/toolkit#69 for context. Basically, this is confusing since we don't doc what this is anywhere

thboop
thboop approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Once we turn plugins into full actions this confusion will no longer occur but this is a great solution for the meantime!

@damccorm damccorm merged commit 94d077c into master Sep 6, 2019
@damccorm damccorm deleted the explanatory-comment branch September 6, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thboop thboop thboop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damccorm @thboop