This repository has been archived by the owner on Mar 4, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 303
create release with body text sourced from file #50
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
bfe866f
try body as file, use as string otherwise
jbolda cf2e5a0
add encoding property
jbolda 15708f2
add new input, error if file not found
jbolda 76860a0
fix encoding
jbolda c06331b
only error on actual attempt at using bodyFromFile and reorder a bit …
jbolda 6d0973e
reorder test mock inputs
jbolda e0754ec
Merge pull request #1 from jbolda/body-markdown
jbolda 3cd5bbb
Update README.md
jbolda b77c216
escape double quotes in eslint command
jbolda d16f415
switch to snake case and body_path
jbolda 7424051
Merge branch 'master' of https://github.com/jbolda/create-release
jbolda 9d21c8a
update readme with body_path
jbolda f37d718
define body_path
e9cf5d9
Merge pull request #2 from ssgglobal/master
jbolda 8210505
Merge branch 'master' into master
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't speak to the style that the actions team prefers, but
bodyPath !== '' &&
is redundant, here. (The boolean value of the empty string isfalse
.) Which would allow further reduction to justif(bodyPath)
. There's no reason to force cast to an actual boolean here because the type casting is already handled by falsiness.