-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show snapshot warnings in the summary #439
Changes from 4 commits
419396d
782549c
0c01e94
7e1f7be
76b8e83
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,9 @@ export function groupDependenciesByManifest( | |
): Map<string, Changes> { | ||
const dependencies: Map<string, Changes> = new Map() | ||
for (const change of changes) { | ||
const manifestName = change.manifest | ||
// If the manifest is null or empty, use a space as the key to avoid | ||
// breaking the HTML rendering later | ||
const manifestName = change.manifest || ' ' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Rather than using invisible characters that could be confusing, maybe let's consider something like There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd be happy to make that kind of change. Maybe |
||
|
||
if (dependencies.get(manifestName) === undefined) { | ||
dependencies.set(manifestName, []) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ thanks for capturing this invariant in a test!