Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Fix: truncate oversized core.summary outputs #788

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

elireisman
Copy link
Contributor

Addresses a bug where the detailed DR report outputs can overflow core.summary, causing the DR Action to throw the following error:

$GITHUB_STEP_SUMMARY upload aborted, supports content up to a size of 1024k, got <REDACTED>. For more information see: https://docs.github.com/actions/using-workflows/workflow-commands-for-github-actions#adding-a-markdown-summary

The long term fix is to refactor the summary.ts package so that each segment of the formatted summary is cached and can be measured and reformatted with care rather than truncated blindly when it is oversized. This will prevent end users missing important details on their vulnerability and license results from the DR run.

@elireisman elireisman self-assigned this Jul 4, 2024
@elireisman elireisman marked this pull request as ready for review July 6, 2024 00:16
@elireisman elireisman requested a review from a team as a code owner July 6, 2024 00:16
@elireisman elireisman marked this pull request as draft July 6, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant