Add optional 'conclusion' argument to emitTelemetry #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If present, will include the value of `conclusion` with the telemetry POST body (gh/gh needs a separate PR to recognize this)
TooManyBees
force-pushed
the
pages/get-build-conclusion
branch
from
a445abf to
1c52af2
Compare
| @@ -22,11 +22,12 @@ async function emitTelemetry() { | |||
| // All variables we need from the runtime are set in the Deployment constructor | |||
| const deployment = new Deployment() | |||
| const telemetryUrl = `${deployment.githubApiUrl}/repos/${deployment.repositoryNwo}/pages/telemetry` | |||
| core.info(`Sending telemetry for run id ${deployment.workflowRun}`) | |||
| const conclusion = core.getInput('conclusion') || null | |||
There was a problem hiding this comment.
Do we need the || null here? I thought that may be the implicit default with JavaScript. @JamesMGreene Would probably know better than me though!
There was a problem hiding this comment.
Oh, it's because the empty string "" is falsy in javascript and truthy in ruby, so on the api side we want data["conclusion"] to have the correct truthiness (technically data["conclusion"].presence does this for us, but I wanted to be explicit).
There was a problem hiding this comment.
undefined is the implicit default in JavaScript but core.getInput(...) in particular will return an empty string by default, so converting those into null values here makes sense to me. 👍🏻
yoannchaudet
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the telemetry endpoint to receive the build job status directly in the request body, rather than needing to look it up.