-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update action to node20 #66
Conversation
@takost Thanks for the PR. This project is old enough to depend on node-fetch, which was superseded by a native Do you mind creating a repo showing a successful run of the Action using your branch and then linking it here? I'll see what's up with CI in the meantime. |
|
@febuiles I have created a repo to test action: . My build passes. I am not sure if it is enough to test the action properly. Please help me to test this change. I am aware of this fetch API change between node versions, but we are going to deprecate Node 16 on our runners in some (near) future. So all |
@takost dependencies were not detected during your run due to the repo being a fork (we don't track those), but everything else looks good so I'm merging! Do you have a deadline for the Node upgrade? Our team handles a much more active Action that's still running v16 (cc @jovel) and would also need attention. |
@febuiles Initial plan was to start warn users about Node.js 16 deprecation Nov-Dec, start forcing execution of actions on Node.js 20 mid April, and start removal Jul-Aug. But Node.js 20 is not fully supported on old OS platforms due to software limitations such update will be breaking changes. I expect that we start final removal of Node.js 16 September-October next year |
Description:
Node 16 has reached end-of-life on 11 Sep 202.
This PR updates the default runtime to node20, rather then node16.
This is supported on all Actions Runners v2.308.0 or later.