Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action to node20 #66

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Update action to node20 #66

merged 5 commits into from
Dec 1, 2023

Conversation

takost
Copy link
Contributor

@takost takost commented Nov 16, 2023

Description:
Node 16 has reached end-of-life on 11 Sep 202.
This PR updates the default runtime to node20, rather then node16.

This is supported on all Actions Runners v2.308.0 or later.

@takost takost requested a review from a team as a code owner November 16, 2023 16:13
@febuiles
Copy link

@takost Thanks for the PR. This project is old enough to depend on node-fetch, which was superseded by a native fetch API in Node 18. This has caused issues with at least another Action upgrade.

Do you mind creating a repo showing a successful run of the Action using your branch and then linking it here? I'll see what's up with CI in the meantime.

@febuiles
Copy link

npm run all should fix it, there are some differences in dist/ I think.

@takost
Copy link
Contributor Author

takost commented Dec 1, 2023

@febuiles I have created a repo to test action: . My build passes. I am not sure if it is enough to test the action properly. Please help me to test this change.

I am aware of this fetch API change between node versions, but we are going to deprecate Node 16 on our runners in some (near) future. So all node16 actions will be forced to run on node20. We need to update all first party Github actions to node20, to be able to continue our work, as officially Node16 is out of support since September.

@febuiles
Copy link

febuiles commented Dec 1, 2023

@takost dependencies were not detected during your run due to the repo being a fork (we don't track those), but everything else looks good so I'm merging!

Do you have a deadline for the Node upgrade? Our team handles a much more active Action that's still running v16 (cc @jovel) and would also need attention.

@febuiles febuiles merged commit b06941e into actions:main Dec 1, 2023
1 check passed
@takost
Copy link
Contributor Author

takost commented Dec 4, 2023

@febuiles Initial plan was to start warn users about Node.js 16 deprecation Nov-Dec, start forcing execution of actions on Node.js 20 mid April, and start removal Jul-Aug. But Node.js 20 is not fully supported on old OS platforms due to software limitations such update will be breaking changes. I expect that we start final removal of Node.js 16 September-October next year

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants