Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

Commit

Permalink
Return HttpClientError instead of Error, have properties for status a…
Browse files Browse the repository at this point in the history
…nd result
  • Loading branch information
dhadka committed Oct 12, 2020
1 parent ab10999 commit 55850f1
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 9 deletions.
3 changes: 3 additions & 0 deletions RELEASES.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
## Releases

## 1.0.9
Throw HttpClientError instead of a generic Error from the \<verb>Json() helper methods when the server responds with a non-successful status code.

## 1.0.7
Update NPM dependencies and add 429 to the list of HttpCodes

Expand Down
21 changes: 14 additions & 7 deletions index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,18 @@ const RetryableHttpVerbs: string[] = ['OPTIONS', 'GET', 'DELETE', 'HEAD']
const ExponentialBackoffCeiling = 10
const ExponentialBackoffTimeSlice = 5

export class HttpClientError extends Error {
constructor(message: string, statusCode: number) {
super(message)
this.name = 'HttpClientError'
this.statusCode = statusCode
Object.setPrototypeOf(this, HttpClientError.prototype)
}

public statusCode: number
public result?: any
}

export class HttpClientResponse implements ifm.IHttpClientResponse {
constructor(message: http.IncomingMessage) {
this.message = message
Expand Down Expand Up @@ -733,13 +745,8 @@ export class HttpClient {
msg = 'Failed request: (' + statusCode + ')'
}

let err: Error = new Error(msg)

// attach statusCode and body obj (if available) to the error object
err['statusCode'] = statusCode
if (response.result) {
err['result'] = response.result
}
let err = new HttpClientError(msg, statusCode)
err.result = response.result

reject(err)
} else {
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@actions/http-client",
"version": "1.0.7",
"version": "1.0.9",
"description": "Actions Http Client",
"main": "index.js",
"scripts": {
Expand Down

0 comments on commit 55850f1

Please sign in to comment.