-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow CODEOWNERS file #483
Comments
hi @Ayc0, thank you for the report. We will take a look at it :) |
This would be great. Just to add a slightly different/the other direction use case: if you use labeller for say |
anything we can do here? |
With actions/labeler#483 still pending, do it manually. A couple of entries matching both files and directories were expanded since, unlike fnmatch(3), minimatch treats slashes specially: - src/include/rbd* -> src/include/rbd* src/include/rbd/** - src/rbd* -> src/rbd* src/rbd*/** - src/test/rbd* -> src/test/rbd* src/test/rbd*/** A bunch of entries under src/tools were combined into: - src/tools/rbd*/** Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
With actions/labeler#483 still pending, do it manually. A couple of entries matching both files and directories were expanded since, unlike fnmatch(3), minimatch treats slashes specially: - src/include/rbd* -> src/include/rbd* src/include/rbd/** - src/rbd* -> src/rbd* src/rbd*/** - src/test/rbd* -> src/test/rbd* src/test/rbd*/** A bunch of entries under src/tools were combined into: - src/tools/rbd*/** Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
With actions/labeler#483 still pending, do it manually. A couple of entries matching both files and directories were expanded since, unlike fnmatch(3), minimatch treats slashes specially: - src/include/rbd* -> src/include/rbd* src/include/rbd/** - src/rbd* -> src/rbd* src/rbd*/** - src/test/rbd* -> src/test/rbd* src/test/rbd*/** A bunch of entries under src/tools were combined into: - src/tools/rbd*/** Signed-off-by: Ilya Dryomov <idryomov@gmail.com> (cherry picked from commit 716996e)
With actions/labeler#483 still pending, do it manually. A couple of entries matching both files and directories were expanded since, unlike fnmatch(3), minimatch treats slashes specially: - src/include/rbd* -> src/include/rbd* src/include/rbd/** - src/rbd* -> src/rbd* src/rbd*/** - src/test/rbd* -> src/test/rbd* src/test/rbd*/** A bunch of entries under src/tools were combined into: - src/tools/rbd*/** Signed-off-by: Ilya Dryomov <idryomov@gmail.com> (cherry picked from commit 716996e)
With actions/labeler#483 still pending, do it manually. A couple of entries matching both files and directories were expanded since, unlike fnmatch(3), minimatch treats slashes specially: - src/include/rbd* -> src/include/rbd* src/include/rbd/** - src/rbd* -> src/rbd* src/rbd*/** - src/test/rbd* -> src/test/rbd* src/test/rbd*/** A bunch of entries under src/tools were combined into: - src/tools/rbd*/** Signed-off-by: Ilya Dryomov <idryomov@gmail.com> (cherry picked from commit 716996e)
With actions/labeler#483 still pending, do it manually. A couple of entries matching both files and directories were expanded since, unlike fnmatch(3), minimatch treats slashes specially: - src/include/rbd* -> src/include/rbd* src/include/rbd/** - src/rbd* -> src/rbd* src/rbd*/** - src/test/rbd* -> src/test/rbd* src/test/rbd*/** A bunch of entries under src/tools were combined into: - src/tools/rbd*/** Signed-off-by: Ilya Dryomov <idryomov@gmail.com> (cherry picked from commit 716996e)
Description:
Add the option to use the CODEOWNERS (+ a file that map some codeowners to labels) to the labeler
For instance:
Justification:
In project with teams, codeowners is a great feature to get pinged, but it cannot really help to view afterwards which teams were pinged by a PR (as the team gets replaced by the person that reviewed the PR).
To fix this, I use labels with a similar subset of the CODEOWNERS config.
But sometimes it can be a bit tricky to find the perfect equivalent for the CODEOWNERS syntax using glob pattern.
Are you willing to submit a PR?
Yes, if this PR is approved, I can work on a PR for that
The text was updated successfully, but these errors were encountered: