-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to preserve manually added labels #624
Comments
Hello @EvieSchwarzIntel! Thank you for the feature request! |
Great, thank you! What would be the estimated complexity in implementing this? |
Could you please describe your use case in a little more detail? The action only manages the labels that are specified in the configuration file. If you want to manage these labels yourself, why do you need to add them to the labeler config file? If you want to add labels in two ways and the action removes them, maybe it is better to change the glob patterns for those labels or create separate labels that will suit your needs? It seems to me that you have labels with an ambiguous non-obvious meaning. Also could you please clarify why the |
Yes
I'll describe 2 situations. 1. Failsafe
Potential issues:
2. Running Coverage/performance/memcheck metrics:
So you end up with these labels: Labeller controlled labels: Manually controlled labels:
Whether or not sync-lables is added, the following behaviour happens: |
I have the same issue. |
…ged` label, works around actions/labeler#624
|
Hello @wheelerlaw! |
I don't think |
Should be able to query https://docs.github.com/en/rest/issues/events#list-issue-events and remove labels if and only if they were added by the |
Description:
I would like add an option to:
sync-labels: does not work in this case.
Could call the option "preserve-labels" or similar.
Description (usecase):
Suppose we have a repo with 2 generations (versions) of a project.
The src code for generations are in 2 different directories.
Some common code is shared.
I define the labeller like so:
labeller.yml:
There are cases where, regardless of the files changed, I want to run tests for both generations.
So I apply the label "GENERATION1_LABELLER_LABEL".
The labeller sees that I haven't changed files in "- 'common_files/.' or 'generation1_files/.'.
It removes the label.
Justification:
Currently we require 2 labels to get this to run.
GENERATION0_LABELLER_LABEL
GENERATION1_LABELLER_LABEL
GENERATION0_MANUAL_LABEL
GENERATION1_MANUAL_LABEL
Are you willing to submit a PR?
Not likely, but a possibility if complexity is low
The text was updated successfully, but these errors were encountered: