-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example fails yaml validation #746
Comments
Hello @boneskull |
This seems to be related to the schema published on https://json.schemastore.org/pull-request-labeler.json being out-of-date. I'm not sure if that's the same one used by VSCode, but I can see the same validation failure in current Jetbrains IDEs, and they automatically fetch the schemas from there. |
To fix that, a PR should be created in the schemastore repo |
I've written an updated schema that should be available already: https://json.schemastore.org/pull-request-labeler-5.json I don't know whether VSCode actually uses those schemas though. |
VSCode itself won't with YAML files, but will do so with an extension, like the Red Hat YAML Extension |
@QuLogic I think there's still something wrong with that schema... Or maybe with JetBrains' YAML validator. Either way, it's warning that the shorthand At least the verbose syntax works OK now (but too bad that I have to add a custom schema mapping to every project in order to use your schema 🥹 ) About VSCode, by itself it only validates the basic YAML syntax (AFAICR, maybe not even that), but it automatically offers "There are extensions in the marketplace for YAML!" the first time you open up one, and the top results will probably all validate using SchemaStore anyway 🤷♂️ |
That form is part of the tests, so if it's failing, it's not due to the schema. |
This behavior seems to be a quirk of Intellij. It is solved if in the JSON schema one replaces
Use:
There seem to be similar issues with Attaching a schema file that works in Intellij, you can add a schema mapping locally until this gets fixed in schemastore.org or in the validator. |
Description:
The example in the README fails YAML schema validation in VSCode
Action version:
v5.0.0
Platform:
Runner type:
Repro steps:
labeler.yml
in.github
Expected behavior:
No validation error
Actual behavior:
See screenshots
The text was updated successfully, but these errors were encountered: