-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub labeler action to v5 #3550
Conversation
832c20a
to
ff2b2c5
Compare
Hmm, I don't quite understand what the compile is complaining about. It seems to work on my actual repo with pre-commit+check-jsonschema, and validates on https://www.jsonschemavalidator.net/ but maybe I'm missing something. |
ff2b2c5
to
fbf1cd5
Compare
255fbd4
to
b839b58
Compare
for more information, see https://pre-commit.ci
Ah, I found that I also found that I missed that file globs/branch names can be singular strings instead of array, so I've added that typing correction, and the example now pass. |
awesome, thanks |
BTW, how does one find these alternate versions on https://www.schemastore.org/json/ ? If I search for 'label', I just get Pull Request Labeler, which is the old one. But https://json.schemastore.org/pull-request-labeler-5.json is online. |
Hmm, yeah it looks like the search feature does not include the recently added schemas. I'll have to look into it a bit more, but I think this issue is relatively low-priority. |
As the original schema did not have a version in the name, I'm a bit unsure whether I should add the version to the new one, the old one, or both, and/or make the non-versioned one the latest or vice-versa.
I also need to write up some tests.