Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub labeler action to v5 #3550

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

QuLogic
Copy link
Contributor

@QuLogic QuLogic commented Jan 25, 2024

As the original schema did not have a version in the name, I'm a bit unsure whether I should add the version to the new one, the old one, or both, and/or make the non-versioned one the latest or vice-versa.

I also need to write up some tests.

@QuLogic QuLogic force-pushed the update-labeler branch 2 times, most recently from 832c20a to ff2b2c5 Compare January 25, 2024 11:23
@QuLogic
Copy link
Contributor Author

QuLogic commented Jan 25, 2024

Hmm, I don't quite understand what the compile is complaining about. It seems to work on my actual repo with pre-commit+check-jsonschema, and validates on https://www.jsonschemavalidator.net/ but maybe I'm missing something.

@QuLogic
Copy link
Contributor Author

QuLogic commented Jan 26, 2024

Ah, I found that pull-request-labeler.json is in the ajvNotStrictMode list, so I've added the new file there as well. I'm not sure why that is needed, as I can run ajv-cli validate on it and it passes.

I also found that I missed that file globs/branch names can be singular strings instead of array, so I've added that typing correction, and the example now pass.

@QuLogic QuLogic marked this pull request as ready for review January 26, 2024 12:18
@hyperupcall
Copy link
Member

awesome, thanks

@hyperupcall hyperupcall merged commit 492854e into SchemaStore:master Jan 26, 2024
3 checks passed
@QuLogic QuLogic deleted the update-labeler branch January 27, 2024 01:11
@QuLogic
Copy link
Contributor Author

QuLogic commented Feb 7, 2024

BTW, how does one find these alternate versions on https://www.schemastore.org/json/ ? If I search for 'label', I just get Pull Request Labeler, which is the old one. But https://json.schemastore.org/pull-request-labeler-5.json is online.

@hyperupcall
Copy link
Member

Hmm, yeah it looks like the search feature does not include the recently added schemas. I'll have to look into it a bit more, but I think this issue is relatively low-priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants